feat: Deprecate prometheus.write.queue#5509
Conversation
|
💻 Deploy preview available (chore: Deprecate prometheus.write.queue): |
docs/sources/reference/components/prometheus/prometheus.write.queue.md
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| func NewComponent(opts component.Options, args Arguments) (*Queue, error) { | ||
| level.Warn(opts.Logger).Log("msg", "prometheus.write.queue is deprecated and will be removed in a future version. Migrate to prometheus.remote_write to prevent future errors.") |
There was a problem hiding this comment.
I know we have talked about deprecation of components in general. Maybe we could add support for that during component registration.
Not required for that in this pr but something we should consider at lest
There was a problem hiding this comment.
I ended up trying this out with a deprecated stability level. I might push it for feedback but I didn't feel great about it. I had to make it an "internal" stability level equivalent to Experimental which I think makes sense just felt a bit awkward.
…queue.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell
left a comment
There was a problem hiding this comment.
Approving for docs
|
I did end up changing this from chore -> feat so it shows up in the changelog. |
|
💻 Deploy preview deleted (feat: Deprecate prometheus.write.queue). |
### Brief description of Pull Request `prometheus.write.queue` is deprecated and will be removed in the future. We have decided to invest further in `prometheus.remote_write` over further investments in `prometheus.write.queue` as an outcome of grafana#5039. ### Issue(s) fixed by this Pull Request Resolves: grafana#5506 ### PR Checklist - [x] Documentation added --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
This reverts commit 726354a.
Brief description of Pull Request
prometheus.write.queueis deprecated and will be removed in the future. We have decided to invest further inprometheus.remote_writeover further investments inprometheus.write.queueas an outcome of #5039.Issue(s) fixed by this Pull Request
Resolves: #5506
PR Checklist