fix(loki.source.file): Update tail_from_end to properly handle file encoding#5429
Merged
fix(loki.source.file): Update tail_from_end to properly handle file encoding#5429
tail_from_end to properly handle file encoding#5429Conversation
tail_from_end now properly handle file encodingtail_from_end to properly handle file encoding
ptodev
reviewed
Feb 4, 2026
ptodev
approved these changes
Feb 4, 2026
grafana-alloybot bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
… encoding (#5429) ### Brief description of Pull Request When `tail_from_end = true` we no longer produce invalid line on first read when reading `UTF-16LE` encoded files. ### Pull Request Details The issue was that `getLastLinePosition` did not take file encoding into account. I moved the logic into `tail.reader` so that we can perform this kind of operation with either configured or detected encoding. ### Issue(s) fixed by this Pull Request Fixes: #5423 ### Notes to the Reviewer <!-- Add any relevant notes for the reviewers and testers of this PR. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [x] Tests updated - [ ] Config converters updated (cherry picked from commit 807ff00)
This was referenced Feb 4, 2026
Merged
Draft
kalleep
added a commit
that referenced
this pull request
Feb 4, 2026
… encoding [backport] (#5436) ## Backport of #5429 This PR backports #5429 to release/v1.13. ### Original PR Author @kalleep ### Description ### Brief description of Pull Request When `tail_from_end = true` we no longer produce invalid line on first read when reading `UTF-16LE` encoded files. ### Pull Request Details The issue was that `getLastLinePosition` did not take file encoding into account. I moved the logic into `tail.reader` so that we can perform this kind of operation with either configured or detected encoding. ### Issue(s) fixed by this Pull Request Fixes: #5423 ### Notes to the Reviewer <!-- Add any relevant notes for the reviewers and testers of this PR. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [x] Tests updated - [ ] Config converters updated --- *This backport was created automatically.* Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
When
tail_from_end = truewe no longer produce invalid line on first read when readingUTF-16LEencoded files.Pull Request Details
The issue was that
getLastLinePositiondid not take file encoding into account. I moved the logic intotail.readerso that we can perform this kind of operation with either configured or detected encoding.Issue(s) fixed by this Pull Request
Fixes: #5423
Notes to the Reviewer
PR Checklist