Conversation
…Unmarshaler for TruncateSourceType
blewis12
approved these changes
Feb 3, 2026
Member
blewis12
left a comment
There was a problem hiding this comment.
Shall we add a basic sanity-check style test for this? Other than that, LGTM
Contributor
Author
|
@blewis12 I added a test to parse alloy syntax for this block. I also noticed that the documentation was wrong. We document |
Contributor
|
💻 Deploy preview deleted (fix(loki.process): Implement encoding.TextMarshaler and encoding.TextUnmarshaler for TruncateSourceType). |
4 tasks
ptodev
approved these changes
Feb 4, 2026
grafana-alloybot bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
…Unmarshaler for TruncateSourceType (#5419) ### Pull Request Details It was impossible to configure `source_type` for `stage.truncate` and would always result in a panic. For these custom enum types we need to implement `encoding.TextUnmarshaler` for it to be configurable. ### Issue(s) fixed by this Pull Request Fixes: #5410 ### Notes to the Reviewer <!-- Add any relevant notes for the reviewers and testers of this PR. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [x] Tests updated - [ ] Config converters updated (cherry picked from commit 8f6c1b3)
This was referenced Feb 4, 2026
Draft
kalleep
added a commit
that referenced
this pull request
Feb 4, 2026
…Unmarshaler for TruncateSourceType [backport] (#5428) ## Backport of #5419 This PR backports #5419 to release/v1.13. ### Original PR Author @kalleep ### Description ### Pull Request Details It was impossible to configure `source_type` for `stage.truncate` and would always result in a panic. For these custom enum types we need to implement `encoding.TextUnmarshaler` for it to be configurable. ### Issue(s) fixed by this Pull Request Fixes: #5410 ### Notes to the Reviewer <!-- Add any relevant notes for the reviewers and testers of this PR. --> ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [x] Tests updated - [ ] Config converters updated --- *This backport was created automatically.* Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
It was impossible to configure
source_typeforstage.truncateand would always result in a panic. For these custom enum types we need to implementencoding.TextUnmarshalerfor it to be configurable.Issue(s) fixed by this Pull Request
Fixes: #5410
Notes to the Reviewer
PR Checklist