fix: add logging wrapper for cloudwatch exporter with support for debug field#4553
Merged
fix: add logging wrapper for cloudwatch exporter with support for debug field#4553
Conversation
kgeckhart
approved these changes
Oct 6, 2025
dehaansa
approved these changes
Oct 6, 2025
kalleep
added a commit
that referenced
this pull request
Oct 9, 2025
…ug field (#4553) * Add logging wrapper for cloudwatch exporter with support for debug field
kalleep
added a commit
that referenced
this pull request
Oct 9, 2025
* loki.source.journal: fix deadlock (#4571) * fix: add logging wrapper for cloudwatch exporter with support for debug field (#4553) * Use sync timeout to decide how long to retry waiting for k8s api for prometheus.operator.* components (#4568) --------- Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com> Co-authored-by: Sam DeHaan <sam.dehaan@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
In #3995 we updated cloudwatch exporter.
With that change we now pass an adapter around our internal logger.
But this adapter assumes that all logging will be pass through as noted by this comment . But the exporter do check if debug logging is enabled and passes that as internal config to aws sdk that does it's own logging and because we always return true for all log level this happens.
We have
debugattribute on this component that should control this.Which issue(s) this PR fixes
Fixes: #4541
Notes to the Reviewer
PR Checklist