misc: add support for inline TLS settings for Prometheus-based components#3524
Merged
rfratto merged 2 commits intografana:mainfrom Apr 13, 2023
Merged
Conversation
erikbaranowski
approved these changes
Apr 12, 2023
Contributor
erikbaranowski
left a comment
There was a problem hiding this comment.
looks like a lint and test to sort but overall LGTM
…ents This updates the prometheus/common dependency to use a fork until prometheus/common#472 is merged. Components which use the prometheus/common dependency for TLS configs will automatically support inline TLS settings. Some components, particularly loki.source.kafka and loki.source.syslog had to be updated as they build their own TLS configs.
9a526e3 to
626225f
Compare
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ents (#3524) This updates the prometheus/common dependency to use a fork until prometheus/common#472 is merged. Components which use the prometheus/common dependency for TLS configs will automatically support inline TLS settings. Some components, particularly loki.source.kafka and loki.source.syslog had to be updated as they build their own TLS configs.
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
…ents (#3524) This updates the prometheus/common dependency to use a fork until prometheus/common#472 is merged. Components which use the prometheus/common dependency for TLS configs will automatically support inline TLS settings. Some components, particularly loki.source.kafka and loki.source.syslog had to be updated as they build their own TLS configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the prometheus/common dependency to use a fork until prometheus/common#472 is merged.
Components which use the prometheus/common dependency for TLS configs will automatically support inline TLS settings. Some components, particularly loki.source.kafka and loki.source.syslog had to be updated as they build their own TLS configs.