-
Notifications
You must be signed in to change notification settings - Fork 506
Add track_timestamps_staleness to prometheus.scrape #5921
Copy link
Copy link
Closed
Labels
enhancementNew feature or requestNew feature or requestfrozen-due-to-ageLocked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.needs-attentionAn issue or PR has been sitting around and needs attention.An issue or PR has been sitting around and needs attention.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestfrozen-due-to-ageLocked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.needs-attentionAn issue or PR has been sitting around and needs attention.An issue or PR has been sitting around and needs attention.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Request
The
track_timestamps_stalenessfeature was added to Prometheus recently. To pick it up, we would need to upgrade to Prometheus v2.48 or above.track_timestamps_stalenessisfalseby default in Prometheus, because it is considered a breaking change. We should consider whether it could be set totruein the Agent by default. For example, does setting this tofalsehave any benefits? Are there any implications to alerts which rely on these metrics, and would that be s serious breaking change to users?Also, we need to go into more detail in the docs about what metrics with explicit timestamps are, and what staleness markers are, so that users can make a decision how to configure
track_timestamps_staleness. This is what the Prometheus docs say fortrack_timestamps_staleness:I personally didn't even know there could be "metrics that have an explicit timestamps present in scraped data". It is also not clear to me what the implications of adding a staleness marker are.
Use case
Setting
track_timestamps_stalenesstotruecould fix a bug where container metrics linger for 5 minutes after a container dies.