Adapt Java version detection to support JEP-322#3892
Merged
bmuschko merged 1 commit intogradle:masterfrom Dec 26, 2017
Merged
Conversation
JEP-322 is a modification to the Java versioning scheme to accommodate the time-based release model that the JDK is moving to. Starting with JDK 10-ea build 36, the changes from this version scheme are in play and the version dection logic now breaks because of the addition of the java.version.date to the version output. This commit adjusts for that. Additionally, future LTS releases of the JDK will contain an appended " LTS" as well, so this commit adjuts for that too. Signed-off-by: Jason Tedor <jason@tedor.me>
Contributor
|
Thanks for providing this pull request. I opened a similar one yesterday but yours covers a bit more. I am going to merge your PR soon plus you get the credit. :-) |
Contributor
Author
|
I am so sorry for missing yours! Thanks for taking mine, I am happy to have contributed. |
Contributor
|
@jasontedor No worries. Your pull request has been merged. Thanks again for your contribution. |
|
Looks like a regression to me with Gradle 4.5.1 and Java 10:
|
Contributor
|
@yay would you mind opening a new issue? Comments on closed issues easily get lost. |
|
Sure, there you go: #4503 |
dliappis
pushed a commit
to dliappis/rally
that referenced
this pull request
Mar 27, 2018
Similar to the work done for elastic#387, following the merge of the Elasticsearch PR[1], Rally needs to require java-10 to build Elasticsearch from source. Bump the configuration version to 14 and adjust migration of existing configs to support building with java-10. Also add needed test cases. Note that building from source with java-10 requires, at minimum, gradle 4.5[2]. This helps us remove a number of additional gradle options that were needed for java-9. So for now, building will fail with gradle <4.5, which will won't be a worry at all once we start using `./gradlew`; this is tracked in issue#412. Closes elastic#450 [1] elastic/elasticsearch#29174 [2] gradle/gradle#3892
dliappis
pushed a commit
to dliappis/rally
that referenced
this pull request
Mar 27, 2018
Similar to the work done for elastic#387, following the merge of the Elasticsearch PR[1], Rally needs to require java-10 to build Elasticsearch from source. Bump the configuration version to 14 and adjust migration of existing configs to support building with java-10. Also add needed test cases and update docs. Note that building from source with java-10 requires, at minimum, gradle 4.5[2]. This helps us remove a number of additional gradle options that were needed for java-9. So for now, building will fail with gradle <4.5, which will won't be a worry at all once we start using `./gradlew`; this is tracked in issue#412. Closes elastic#450 [1] elastic/elasticsearch#29174 [2] gradle/gradle#3892
dliappis
added a commit
to elastic/rally
that referenced
this pull request
Mar 28, 2018
Similar to the work done for #387, following the merge of the Elasticsearch PR[1], Rally needs to require java-10 to build Elasticsearch from source. Bump the configuration version to 14 and adjust migration of existing configs to support building with java-10. Also add needed test cases and update docs. Note that building from source with java-10 requires, at minimum, gradle 4.5[2]. This helps us remove a number of additional gradle options that were needed for java-9. So for now, building will fail with gradle <4.5, which will won't be a worry at all once we start using `./gradlew`; this is tracked in issue#412. Closes #450 Relates #451 [1] elastic/elasticsearch#29174 [2] gradle/gradle#3892
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JEP-322 is a modification to the Java versioning scheme to accommodate the time-based release model that the JDK is moving to. Starting with JDK 10-ea build 36, the changes from this version scheme are in play and the version dection logic now breaks because of the addition of the java.version.date to the version output. This commit adjusts for that. Additionally, future LTS releases of the JDK will contain an appended " LTS" as well, so this commit adjuts for that too.
Signed-off-by: Jason Tedor jason@tedor.me
Closes #3849