Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Restrict OpControlBarrier, OpMemoryBarrier#31

Merged
zoddicus merged 2 commits intogpuweb:masterfrom
dneto0:issue-28
Jun 14, 2019
Merged

Restrict OpControlBarrier, OpMemoryBarrier#31
zoddicus merged 2 commits intogpuweb:masterfrom
dneto0:issue-28

Conversation

@dneto0
Copy link
Copy Markdown
Contributor

@dneto0 dneto0 commented Jun 10, 2019

Fixes #28

- Refactor description of Memory Semantics bits, describing subsets
  of mask bits for: Order, Storage Class, and Propagation.
- Make a new subsections for sets of instructions that need further
  qualification, grouped according to SPIR-V instruction sections.
- Move restrictions of control barrier, memory barrier, and atomics
  to their own corresponding sections.
  - Update Memory Semantics and Scope restrictions reflect
    decisions in #28:
      - OpMemoryBarrier is only used for intra-invocation fence

dneto0 added 2 commits May 16, 2019 23:25
Fixes gpuweb#28

- Refactor description of Memory Semantics bits, describing subsets
  of mask bits for: Order, Storage Class, and Propagation.
- Make a new subsections for sets of instructions that need further
  qualification, grouped according to SPIR-V instruction sections.
- Move restrictions of control barrier, memory barrier, and atomics
  to their own corresponding sections.
  - Update Memory Semantics and Scope restrictions reflect
    decisions in gpuweb#28:
      - OpMemoryBarrier is only used for intra-invocation fence
@dneto0 dneto0 requested a review from zoddicus June 10, 2019 21:55
@zoddicus zoddicus merged commit 131313e into gpuweb:master Jun 14, 2019
@dneto0 dneto0 deleted the issue-28 branch June 15, 2019 07:13
dneto0 added a commit to dneto0/spirv-execution-env that referenced this pull request Nov 26, 2019
Prior PR gpuweb#31 incorrectly used Workgroup scope for OpMemoryBarrier.

Fixes gpuweb#28 correctly
dneto0 added a commit that referenced this pull request Nov 26, 2019
Prior PR #31 incorrectly used Workgroup scope for OpMemoryBarrier.

Fixes #28 correctly
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The only OpMemoryBarrier is invocation-scope image fence

2 participants