Add time query on GPUCommandBuffer #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getExecutionTime return the the total time, in seconds, that GPU execute this command buffer
Kangz
reviewed
Jun 19, 2020
Kangz
reviewed
Jun 19, 2020
kainino0x
reviewed
Jun 19, 2020
Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
kainino0x
reviewed
Jun 22, 2020
0b6db3f to
9bb9f38
Compare
kvark
approved these changes
Jun 24, 2020
Contributor
kvark
left a comment
There was a problem hiding this comment.
Thank you for addressing this!
Contributor
|
editors TODO: figure out what happens if command buffer is an error |
Contributor
|
resolution: resolve to 0 on error, to avoid the same error being surfaced in multiple ways. (Better to resolve than to leave pending, so user async code doesn't stall unexpectedly.) |
kainino0x
reviewed
Jul 6, 2020
JusSn
reviewed
Jul 13, 2020
JusSn
reviewed
Jul 13, 2020
JusSn
reviewed
Jul 13, 2020
JusSn
reviewed
Jul 13, 2020
JusSn
reviewed
Jul 13, 2020
JusSn
approved these changes
Jul 13, 2020
Contributor
JusSn
left a comment
There was a problem hiding this comment.
Some grammar nits. Thank you!
Co-authored-by: Justin Fan <jussnf@gmail.com>
This was referenced Jan 6, 2021
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…#870) Following WebGPU SPEC, The depth aspect of Depth24UnormStencil8 texture format cannot be selected in a texture to buffer copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getExecutionTime return the the total time, in seconds, that GPU execute this command buffer. (#614 )
Preview | Diff