Add Queue/writeBuffer method #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
May 4, 2020
Contributor
Author
|
Thanks @kainino0x ! Your notes are addressed now. |
austinEng
approved these changes
May 4, 2020
Contributor
austinEng
left a comment
There was a problem hiding this comment.
One comment, otherwise looks great
Contributor
Author
|
Thanks @austinEng ! I agree, although there are many other places where we could throw. But this is a start :) |
kainino0x
approved these changes
May 5, 2020
austinEng
approved these changes
May 5, 2020
Contributor
Contributor
Author
|
Nothing is missing, as far as I know. Just don't want to self-merge, and giving more chance for folks outside of Google-Mozilla to look. Please feel free to merge, especially since it's blocking you. |
This was referenced May 7, 2020
Contributor
|
If anyone else still wants to review, please do so and we can follow up. |
7 tasks
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
May 13, 2020
653: Implement Queue::write_buffer r=nobody a=kvark Implements gpuweb/gpuweb#749 TODO: - [x] handle a case where the buffer is dropped while there is a pending write. Edit: we bump the submission index on the buffer, so it will be kept alive. - [x] properly free the temporary buffer and memory - [x] properly destroy the pending command buffer on device drop - [x] tweak the linear allocator settings - bumped to 16 megs - [x] provide a patch to wgpu-rs and verify it works on the examples - gfx-rs/wgpu-rs#307 - [x] provide a patch to wgpu-native - gfx-rs/wgpu-native#25 - [x] check/fix the trace/replay support Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
* Add Queue/writeBuffer method * Address Kai's comments * Throw under some conditions in writeBuffer
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
* Add Queue/writeBuffer method * Address Kai's comments * Throw under some conditions in writeBuffer
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the
writeBufferproposal moved out of #509Preview | Diff