Skip to content

Conversation

@kainino0x
Copy link
Contributor

@kainino0x kainino0x commented Mar 13, 2020

These have been renamed from rowPitch and imageHeight.
Also touches some surrounding material/definitions.

Fixes #148
Supersedes #519


💥 Error: write EPROTO 140049978214272:error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version:../deps/openssl/openssl/ssl/s23_clnt.c:772:

💥 ###

PR Preview failed to build. (Last tried on Mar 13, 2020, 7:48 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.

🔗 Related URL

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

These have been renamed from rowPitch and imageHeight.
Also touches some surrounding material/definitions.
@kainino0x kainino0x requested review from JusSn and kvark March 13, 2020 07:48
Copy link
Contributor

@JusSn JusSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it. ship it

@kainino0x kainino0x merged commit 7f4b88a into gpuweb:master Mar 16, 2020
@kainino0x kainino0x deleted the bytesPerRow branch March 16, 2020 18:32
JusSn pushed a commit to JusSn/gpuweb that referenced this pull request Jun 8, 2020
These have been renamed from rowPitch and imageHeight.
Also touches some surrounding material/definitions.
JusSn pushed a commit to JusSn/gpuweb that referenced this pull request Jun 8, 2020
These have been renamed from rowPitch and imageHeight.
Also touches some surrounding material/definitions.
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
The WebGPU spec now requires that this decoration be always present for
compute stage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider renaming BufferCopyView.imageHeight

4 participants