Fix tags that cause build errors in the WGSL spec#5046
Merged
kainino0x merged 2 commits intogpuweb:mainfrom Jan 21, 2025
Merged
Fix tags that cause build errors in the WGSL spec#5046kainino0x merged 2 commits intogpuweb:mainfrom
kainino0x merged 2 commits intogpuweb:mainfrom
Conversation
Member
Author
|
@kainino0x there seems to be similar issues in the API spec too. This PR only handles the WGSL ones. Thank you! |
alan-baker
approved these changes
Jan 20, 2025
Member
Author
|
It seems like we can't merge with failing CI anymore (this only takes care of WGSL side). I guess we can either merge this first or the API side. Thank you! |
kainino0x
reviewed
Jan 21, 2025
Contributor
|
Temporarily adjusted the rule so I could land this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the closing of a few tags which are causing build to fail, blocking PRs such as #5042 due to WGSL spec.
Thank you!