Set currentTexture to null on presentation#3228
Merged
kainino0x merged 2 commits intogpuweb:mainfrom Jul 23, 2022
Merged
Conversation
Without this, `getCurrentTexture()` doesn't know it's supposed to allocate a new texture, it just keeps using the destroyed one. And related language tweaks. Issue introduced in gpuweb#2905. This PR still implements the behavior described and agreed upon there. Issue found in whatwg/html#8123.
Contributor
|
Previews, as seen when this build job started (36429e7): |
Contributor
|
Previews, as seen when this build job started (96f9ed0): |
jdarpinian
pushed a commit
to jdarpinian/gpuweb
that referenced
this pull request
Aug 12, 2022
* Set currentTexture to null on presentation Without this, `getCurrentTexture()` doesn't know it's supposed to allocate a new texture, it just keeps using the destroyed one. And related language tweaks. Issue introduced in gpuweb#2905. This PR still implements the behavior described and agreed upon there. Issue found in whatwg/html#8123. * nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this,
getCurrentTexture()doesn't know it's supposed toallocate a new texture, it just keeps using the destroyed one.
And related language tweaks.
Issue introduced in #2905. This PR still implements the behavior
described and agreed upon there. Issue found in whatwg/html#8123.