Skip to content

[editorial] Add definitions for built-in values #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dneto0 merged 1 commit into from
Jul 18, 2022
Merged

[editorial] Add definitions for built-in values #3179

dneto0 merged 1 commit into from
Jul 18, 2022

Conversation

@alan-baker
Copy link
Contributor

@alan-baker alan-baker commented Jul 12, 2022

Fixes #3177

  • Add definitions for the entries in the built-in value table
  • Change references to specific values into links

@alan-baker
[editorial] Add definitions for built-in values
9eff902 
Fixes gpuweb#3177

* Add definitions for the entries in the built-in value table
* Change references to specific values into links
@alan-baker alan-baker added wgsl WebGPU Shading Language Issues copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) labels Jul 12, 2022
@alan-baker alan-baker requested a review from dneto0 July 12, 2022 19:25
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2022

Previews, as seen when this build job started (9eff902):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

dneto0
dneto0 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dneto0 dneto0 merged commit 3f0e03b into gpuweb:main Jul 18, 2022
jdarpinian pushed a commit to jdarpinian/gpuweb that referenced this pull request Aug 12, 2022
@alan-baker @jdarpinian
[editorial] Add definitions for built-in values (gpuweb#3179)
aa8107c 
Fixes gpuweb#3177

* Add definitions for the entries in the built-in value table
* Change references to specific values into links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dneto0 dneto0 dneto0 approved these changes

Assignees

No one assigned

Labels

copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) wgsl WebGPU Shading Language Issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wgsl: Make definitions for each builtin value, so we can do things like [=builtin/position=]

2 participants

@alan-baker @dneto0