Skip to content

Add rg11b10ufloat-renderable feature#3170

Merged
kainino0x merged 1 commit intogpuweb:mainfrom
kainino0x:rg11b10ufloat-renderable
Jul 8, 2022
Merged

Add rg11b10ufloat-renderable feature#3170
kainino0x merged 1 commit intogpuweb:mainfrom
kainino0x:rg11b10ufloat-renderable

Conversation

@kainino0x
Copy link
Copy Markdown
Contributor

Makes rg11b10ufloat support both rendering and multisampling.

Fixes #2648

@kainino0x kainino0x added copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet labels Jul 8, 2022
@kainino0x kainino0x requested a review from toji July 8, 2022 02:36
Copy link
Copy Markdown
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sounds like this will be a useful format for rendering when it's available.

@lokokung
Copy link
Copy Markdown
Contributor

lokokung commented Dec 6, 2022

For the most part, these tests seem to be already implemented here, but opened a re-review CTS draft issue: val: texture,rg11b10ufloat_renderable to make sure we verify the test coverage once #3566 is closed up. (Removing 'needs-cts-label').

@lokokung lokokung removed the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rg11b10ufloat as valid render attachment format

3 participants