Explicitly specify precision for color space conversions #2841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The precision requirement is not actually very high; I considered requiring single-precision float precision, but that may be excessive in many cases (especially unorm8->unorm8). And float16 has lower precision than unorm16 for some ranges, so would be insufficiently precise.
toji
approved these changes
May 6, 2022
Member
toji
left a comment
There was a problem hiding this comment.
Seems like the most sensible approach. LGTM!
github-actions bot
added a commit
that referenced
this pull request
May 6, 2022
SHA: 0ce2c2f Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
May 6, 2022
SHA: 0ce2c2f Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
May 6, 2022
SHA: 0ce2c2f Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jdarpinian
pushed a commit
to jdarpinian/gpuweb
that referenced
this pull request
Aug 12, 2022
The precision requirement is not actually very high; I considered requiring single-precision float precision, but that may be excessive in many cases (especially unorm8->unorm8). And float16 has lower precision than unorm16 for some ranges, so would be insufficiently precise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The precision requirement is not actually very high; I considered
requiring single-precision float precision, but that may be excessive in
many cases (especially unorm8->unorm8). And float16 has lower precision
than unorm16 for some ranges, so would be insufficiently precise.
Fixes #1482
Preview | Diff