Skip to content

Refine the supported swapchain formats #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jchen10 merged 1 commit into from
Jan 25, 2022
Merged

Refine the supported swapchain formats #2522

jchen10 merged 1 commit into from
Jan 25, 2022

Conversation

@jchen10
Copy link
Contributor

@jchen10 jchen10 commented Jan 21, 2022 •
edited by pr-preview bot
Loading

This removes the "-srgb" formats, and adds "rgba16float" and "rgb10a2unorm".

Fixes: #1231

Preview | Diff

@jchen10
Copy link
Contributor Author

jchen10 commented Jan 21, 2022

@kainino0x PTAL

@jchen10
Copy link
Contributor Author

jchen10 commented Jan 21, 2022

@kainino0x BTW, could you please add me into the gpuweb member group, so that I could work on cts/spec more conveniently? Thanks!

@kainino0x
Copy link
Contributor

kainino0x commented Jan 21, 2022

@kainino0x BTW, could you please add me into the gpuweb member group, so that I could work on cts/spec more conveniently? Thanks!

Invite sent!

kainino0x
kainino0x approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although let's give the PR some time for other people to see it).

As for the exact set of formats we're adding here, this looks good but I commented here we still need to evaluate rgb10a2 and make sure it doesn't run into any implementation issues.
#1231 (comment)

@jchen10
Refine the supported swapchain formats
0549a5d 
This removes the "-srgb" formats, and adds "rgba16float".

Fixes: gpuweb#1231
@jchen10
Copy link
Contributor Author

jchen10 commented Jan 21, 2022

Thanks @kainino0x . Sounds fair regarding rgb10a2unorm. Let's add it later in another PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2022

Previews, as seen when this build job started (0549a5d):
WebGPU | IDL
WGSL
Explainer

@kainino0x kainino0x added the tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue label Jan 21, 2022
@jchen10 jchen10 merged commit 72ad499 into gpuweb:main Jan 25, 2022
github-actions bot added a commit that referenced this pull request Jan 25, 2022
@jchen10 @github-actions
Refine the supported swapchain formats (#2522)
ca4fb61 
SHA: 72ad499
Reason: push, by @jchen10

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jan 25, 2022
@jchen10 @github-actions
Refine the supported swapchain formats (#2522)
b4152a2 
SHA: 72ad499
Reason: push, by @jchen10

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jan 25, 2022
@jchen10 @github-actions
Refine the supported swapchain formats (#2522)
e7da93a 
SHA: 72ad499
Reason: push, by @jchen10

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kainino0x kainino0x mentioned this pull request Feb 7, 2022
Draft
@kainino0x kainino0x removed the tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Open questions about swap chain formats

2 participants

@jchen10 @kainino0x