Skip to content

CopyExternalImageToTexture: Support copy from webgpu context canvas/offscreenCanvas#2375

Merged
kainino0x merged 1 commit intogpuweb:mainfrom
shaoboyan:webgpu-context
Dec 15, 2021
Merged

CopyExternalImageToTexture: Support copy from webgpu context canvas/offscreenCanvas#2375
kainino0x merged 1 commit intogpuweb:mainfrom
shaoboyan:webgpu-context

Conversation

@shaoboyan
Copy link
Copy Markdown
Contributor

@shaoboyan shaoboyan commented Dec 2, 2021

Address #2350.


Preview | Diff

@shaoboyan shaoboyan requested a review from kainino0x December 2, 2021 05:46
@kvark kvark requested a review from kdashg December 2, 2021 18:44
@kainino0x kainino0x linked an issue Dec 3, 2021 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kangz
Copy link
Copy Markdown
Contributor

Kangz commented Dec 15, 2021

This is a trivial change, can we land it without the other review?

@kainino0x
Copy link
Copy Markdown
Contributor

Sure, was agreed in meeting.

@kainino0x kainino0x merged commit be11fc9 into gpuweb:main Dec 15, 2021
github-actions bot added a commit that referenced this pull request Dec 15, 2021
…ffscreenCanvas (#2375)

SHA: be11fc9
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Dec 15, 2021
…ffscreenCanvas (#2375)

SHA: be11fc9
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Dec 15, 2021
…ffscreenCanvas (#2375)

SHA: be11fc9
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support webgpu context canvas for copyExternalImageToTexture

3 participants