Specify copyTextureToTexture format compatibility#2329
Merged
kvark merged 2 commits intogpuweb:mainfrom Nov 23, 2021
Merged
Conversation
Specify that copyTextureToTexture is only valid between equal formats, or if the formats diffen only in whether they have `-srgb`. Clean up a few bits of text regarding depth/stencil formats. Add the optional-feature depth/stencil formats to the format table. Fixes gpuweb#2322 Fixes gpuweb#1464
Contributor
Contributor
Kangz
approved these changes
Nov 22, 2021
kvark
approved these changes
Nov 23, 2021
kainino0x
added a commit
to kainino0x/gpuweb
that referenced
this pull request
Nov 24, 2021
Fixes gpuweb#1479 (which was mostly already fixed by gpuweb#2329).
kainino0x
added a commit
to kainino0x/gpuweb
that referenced
this pull request
Nov 24, 2021
Fixes gpuweb#1479 (which was mostly already fixed by gpuweb#2329).
kvark
pushed a commit
that referenced
this pull request
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify that copyTextureToTexture is only valid between equal formats,
or if the formats diffen only in whether they have
-srgb.Clean up a few bits of text regarding depth/stencil formats.
Add the optional-feature depth/stencil formats to the format table.
Fixes #2322
Fixes #1464
Preview | Diff