Replace depth-clamp feature with depth-clip feature#2139
Merged
kainino0x merged 4 commits intogpuweb:mainfrom Nov 1, 2021
Merged
Replace depth-clamp feature with depth-clip feature#2139kainino0x merged 4 commits intogpuweb:mainfrom
kainino0x merged 4 commits intogpuweb:mainfrom
Conversation
Add a line that frag_depth is always clamped to the viewport.
Contributor
kvark
requested changes
Sep 28, 2021
kainino0x
commented
Oct 4, 2021
Contributor
kainino0x
commented
Oct 4, 2021
|
|
||
| Issue: fill out this section | ||
|
|
||
| ### Output Merging ### {#output-merging} |
Contributor
Author
There was a problem hiding this comment.
Tentatively added this new section, is it in the right spot? And what should it be called?
Contributor
Author
There was a problem hiding this comment.
I'm landing this but this bit will conflict with #2162. We can resolve this question there since it's the editorial one for this section.
Contributor
Kangz
reviewed
Oct 5, 2021
kvark
approved these changes
Oct 5, 2021
Contributor
Author
|
@litherum I know you expressed some interest in understanding the issue (#2100). Do you still want to do that? And if so review this (small) PR? I think #2100 (comment) should be a good starting point in the thread. |
toji
approved these changes
Nov 1, 2021
Contributor
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2021
SHA: 00751e0 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2021
SHA: 00751e0 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2021
SHA: 00751e0 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal.
Fixes #2100.
Preview | Diff