Add more clarifications in "Depth/stencil formats"#1463
Merged
kvark merged 2 commits intogpuweb:mainfrom Mar 1, 2021
Merged
Conversation
Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
Kangz
reviewed
Feb 24, 2021
| - {{GPUTextureFormat/depth24plus}}, {{GPUTextureFormat/depth24plus-stencil8}} (depth aspect) | ||
|
|
||
| The {{GPUTextureFormat/depth32float}} format can only the destination if copied from another texture of the same format. It can also be a source of copies into {{GPUTextureFormat/r32float}}. | ||
| Additionally, {{GPUTextureFormat/depth32float}} textures can be copied into {{GPUTextureFormat/depth32float}} and {{GPUTextureFormat/r32float}} textures. |
Contributor
There was a problem hiding this comment.
This says depth32float can be copied into depth32float which doesn't seem super helpful to have in addition to other rules. Did we mean depth32float-stencil8?
Contributor
There was a problem hiding this comment.
No, this was my intent. Are you saying we don't need to specify it because copies within the same format are always valid? I'd argue the list just above this one also specifies copies within the same format are valid, but isn't as explicit.
The point is that nothing can copy into depth32float except for depth32float.
I forgot about depth32float-stencil8, it's not even mentioned anywhere in this section yet, but it needs to be.
kvark
approved these changes
Mar 1, 2021
Contributor
kvark
left a comment
There was a problem hiding this comment.
Agreed to land and iterate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview | Diff