Add bool vector coercion #1362
Merged
Add bool vector coercion #1362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj2
reviewed
Jan 25, 2021
| <td>`vec`|N|<`bool`>`(`|e|`)` : vec|N|<bool> | ||
| <td>Component-wise coercion of a unsigned integer vector to a boolean vector.<br> | ||
| Component |i| of the result is `bool(`|e|`[`|i|`])`<br> | ||
| (OpINotEqual to compare |e| against a zero vector.) |
Member
There was a problem hiding this comment.
I don't think this line is right given we're doing component wise checks?
Contributor
Author
There was a problem hiding this comment.
OpINotEqual operates on vector operands, producing a vector result of the same component count, and "Results are computed per component."
| <td>`vec`|N|<`bool`>`(`|e|`)` : vec|N|<bool> | ||
| <td>Component-wise coercion of a signed integer vector to a boolean vector.<br> | ||
| Component |i| of the result is `bool(`|e|`[`|i|`])`<br> | ||
| (OpINotEqual to compare |e| against a zero vector.) |
| <td>`vec`|N|<`bool`>`(`|e|`)` : vec|N|<bool> | ||
| <td>Component-wise coercion of a floating point vector to a boolean vector.<br> | ||
| Component |i| of the result is `bool(`|e|`[`|i|`])`<br> | ||
| (OpFUnordNotEqual to compare |e| against a zero vector.) |
dj2
approved these changes
Jan 25, 2021
kvark
approved these changes
Jan 26, 2021
kdashg
approved these changes
Jan 29, 2021
Contributor
|
Doesn't look controversial, merging |
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This CL adds unimplemented tests for the `dpdyFine` builtin. Issue: gpuweb#1254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1355