Show channel or episode titles in delete dialog #983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a second, and better, indicator of which channel or episode is being deleted. Only 8 titles up to 60 characters each are shown to avoid excessively large dialogs.
Member
|
looks good 👍 |
Member
Author
|
I think it looks better without the blank lines between each title and doesn't drown out the message. @elelay Does it still look good to you? |
Member
|
yes, it's clearer now 👍 |
elelay
added a commit
that referenced
this pull request
Apr 23, 2021
Cherry-picked from #983 Show channel or episode titles in delete dialog
Member
|
Cherry-picked commits because merge seemed overly complex |
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a second, and better, indicator of which channel or episode is being deleted. Only 8 titles up to 60 characters each are shown to avoid excessively large dialogs.
The titles can blend with the final delete message. Should the final message be bold? Or should titles have a prefix such as '• '?
Should the 8 and 60 be adjusted? The dialog appears to self limit its width (wrapping lines), and 4-5@120 would allow fewer double line titles to be shown. It is less likely someone would read more than 4-5 titles when mass deleting, and showing more of long titles might be better.