Fix uncaught exception on channel list key navigation #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After searching, the channel list treeview sometimes does not have a selected item, leading to an invalid iterator when navigating the list with arrow keys. Select the first episode item in the TreeView model in this case.
Member
|
I can confirm the problem and that this fixes it, thanks. |
Member
|
With or without this patch, pressing up or down when channel and episode lists are empty also throws this exception. The following two lines fixes it. |
elelay
added a commit
that referenced
this pull request
Jan 5, 2021
Fix uncaught exception on channel list key navigation
Member
|
Merged, thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing a long search term to the channel list search until there is no matching channels left, and then shortening the search term with backspace results in a channel treeview with episodes, but with nothing selected.
Using the arrow key navigation in this state (like pressing 2 times Up arrow) results in this uncaught exception:
This PR selects the first episode in the list, when keyboard-navigating in a treeview without selection.