-
-
Notifications
You must be signed in to change notification settings - Fork 217
Get correct window size when saving UI state #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have been using a patch to prevent window walking because the event position includes window decorations. But But https://developer.gnome.org/gtk3/stable/GtkWindow.html#gtk-window-get-position says the application shouldn't save and restore window position, so maybe gpodder's position code should be removed. My window manager remembers the size and location and automatically restores the window, but then gpodder does its own thing and walks away. @elelay Do you know anything about this? |
|
Using the i3 tiling manager I don't see the restored size. |
|
At least on gnome-shell under wayland event.{xy} and widget.get_position() return constant values after moving the window. IIRC wayland clients do not know their position on screen (but maybe there's a mechanism to ask for it from the compositor). This is maybe true for compositing window managers on X11 as well. Given this, maybe the position saving should be removed from gPodder and left to the windowing system to worry about. Restoring the window size on other hand is useful, at least on gnome. The default window size is too small to be useful. |
|
I agree, gpodder should only save and restore the size with widget.get_size(), and the position code should be removed. |
|
I added a patch to this PR which removes saving and restoring window position. |
|
Oh, just got this in latest version 3.10.18 (2021-04-09) for Windows 10, and it's disappointing that gPodder now doesn't open into the place where I closed it. Any chance of making this behaviour a user option? |
|
@Platypus123 I am working on restoring this feature and will have a new release out in the next day or two. |
The code was removed in #933 because GTK+ recommends window managers should manage window position, not applications. However, Windows, Mac(?) and some window managers don't have this ability and gPodder becomes less usable without it.
|
That's great! I've actually gone back to 3.10.17 for the time being. |
|
It has been fixed in 3.10.19. |
The main gPodder window is growing after restart. This patch should fix it. Only tested on Gnome, so please check if this breaks on other environments.