Log youtube-dl version and warn if known to have issues. #919
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, good idea.
But how can one update the youtube-dl which is used by GPO under windows? It’s something I really would like to know.
When I use youtube-dl stand alone I do it with „youtube-dl -U“. But I haven’t figured out where this program is actually located in GPO and how to make sure GPO is using the latest version.
I appreciate your work on GPO.
Thanks
Ben
… Am 09.12.2020 um 04:28 schrieb auouymous ***@***.***>:
The logging might help with debugging youtube-dl issues, and the warning can be used to flag known broken versions.
You can view, comment on, or merge this pull request online at:
#919 <#919>
Commit Summary
Log youtube-dl version and warn if known to have issues.
File Changes
M share/gpodder/extensions/youtube-dl.py <https://github.com/gpodder/gpodder/pull/919/files#diff-98bfaec2c48230e6b523a33b01cb6c06c7a370411481802433f0abc753403693> (14)
Patch Links:
https://github.com/gpodder/gpodder/pull/919.patch <https://github.com/gpodder/gpodder/pull/919.patch>
https://github.com/gpodder/gpodder/pull/919.diff <https://github.com/gpodder/gpodder/pull/919.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#919>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNRICUDRCF24VGQQHK567DST3VHFANCNFSM4US37SLQ>.
|
Member
Author
|
The warning would only trigger for issues known at the time of a gpodder release. When 3.10.17 was released, it was known that youtube-dl versions before 2020.11.12 had issues. Even though 3.10.17 fixed part of the issue, an updated youtube-dl would be required to properly work. I assume the windows version includes the version of youtube-dl available at time of release, and this warning would never be shown for someone using a bundled version. If this is true, you can update the bundled youtube-dl by grabbing the newest git version of gpodder at https://ci.appveyor.com/project/elelay/gpodder/build/artifacts. |
Member
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging might help with debugging youtube-dl issues, and the warning can be used to flag known broken versions.