Skip to content

Conversation

@auouymous
Copy link
Member

Allows live streams to be streamed (but not downloaded) while live. The video player must support HLS m3u8 URLs (ffplay does). It adds a new Video setting to select HLS formats, and supports custom formats in Edit config.

@elelay
Copy link
Member

elelay commented Sep 12, 2020

Looks good.
I've added a fix to allow streaming videos if a custom video player was selected but the default audio player.
Do you agree?

@auouymous
Copy link
Member Author

I don't understand what you said.

@elelay
Copy link
Member

elelay commented Sep 13, 2020

gPodder enables the Stream menu item only if the user has selected a player (vlc, ...).
episodes are streamed by executing the selected player with the download url.
audio episodes execute the audio player, video episodes the video player.

Before 8503fef the Stream menu item was disabled for video episodes (youtube live video) even if I selected VLC as video player because I kept the default audio player. Now gPodder looks at the video player for video episodes and the audio player for other kinds.

@auouymous
Copy link
Member Author

Ah, I had a non-default audio player and the stream option does dim when changed to default. LGTM.

@elelay
Copy link
Member

elelay commented Sep 13, 2020

Let's merge, then!
Thanks,

@elelay elelay merged commit 642b23b into gpodder:master Sep 13, 2020
@auouymous auouymous deleted the youtube-live-streaming branch September 13, 2020 22:49
auouymous added a commit to auouymous/gpodder that referenced this pull request Mar 20, 2022
Streaming was always possible (gpodder#867) for all audio and video episodes if
an audio player was configured. Now it is only possible if a player is
configured for the episode's type.

Methods have been added to PodcastEpisode that are either now used by
actions or replicate the conditions used by actions to filter
selections. This will help prevent mismatched conditions between
play_or_download() and episode actions. And play_or_download() is easier
to reason about and should prevent future bugs such as gpodder#1250.

Fixes gpodder#1250.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants