Add socks to settings #1592
Merged
Add socks to settings #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a9d3ed to
ad69160
Compare
0ac05d3 to
9d39b70
Compare
And add the ui and glue code to set a proxy in that tab
The base config class has an observer facility. Using that we can define an observer inside a closure containing a reference to the UIConfig instance the application is using. And the observer will update the global gpodder.config._proxies variable that various network calls check to get the desired proxies.
9d39b70 to
6a49297
Compare
auouymous
requested changes
Feb 20, 2024
Member
auouymous
left a comment
There was a problem hiding this comment.
gpo crashes with this patch installed.
- youtube-dl should use the proxy settings (it's a separate plugin with a settings menu of its own)
The proxy prefs are in gpodder, any extension capable of using the proxy prefs should use it.
https://stackoverflow.com/questions/46389519/how-to-embed-socks5-proxy-in-youtube-dls-python-code
Contributor
Author
|
Thank you for the feedback. I'll fix them and investigate the crash |
auouymous
requested changes
Mar 8, 2024
Member
auouymous
left a comment
There was a problem hiding this comment.
gpo doesn't initialize the _proxies variable. Adding the following to the end of gPodderCli init seems to work.
observer = gpodder.config.get_network_proxy_observer(self._config)
self._config.add_observer(observer)
# Trigger the global gpodder.config._proxies observer contraption to initialize it.
observer("network.", None, None)
Member
|
Thank you for implementing this. |
snorkelopsstgtesting1-spec
pushed a commit
to snorkel-marlin-repos/gpodder_gpodder_pr_1592_df9f979f-d4b3-47ad-ac55-6658c6932e11
that referenced
this pull request
Oct 22, 2025
Original PR #1592 by masoudd Original: gpodder/gpodder#1592
6 tasks
snorkelopstesting4-web
added a commit
to snorkel-marlin-repos/gpodder_gpodder_pr_1592_df9f979f-d4b3-47ad-ac55-6658c6932e11
that referenced
this pull request
Oct 22, 2025
Merged from original PR #1592 Original: gpodder/gpodder#1592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current UI:
Please let me know if anything needs to change.