Skip to content

Conversation

@batman004
Copy link
Contributor

@batman004 batman004 commented Dec 7, 2022

  • Added function to rename all downloaded episodes
  • Added loader to show the progress of updating names

@auouymous auouymous linked an issue Dec 7, 2022 that may be closed by this pull request
@auouymous
Copy link
Member

There is still a linting issue, but the feature crashes for me. It needs to filter the episode list using episode.state == gpodder.STATE_DOWNLOADED so on_episode_downloaded() is only called for downloaded episodes, and also to get a correct count for progress indicator.

episodes = [row[model.C_EPISODE] for row in model if row[model.C_EPISODE].state == gpodder.STATE_DOWNLOADED]

@batman004
Copy link
Contributor Author

batman004 commented Dec 8, 2022

Fixed it. the lint tests pass locally for me now. Also about the episode filtering issue, I think declaring episodes how you have shown should work. I'll update my PR. Thanks

@auouymous auouymous merged commit 486fa9d into gpodder:master Dec 8, 2022
@auouymous
Copy link
Member

Merged, thanks for adding this feature.

@batman004
Copy link
Contributor Author

Thanks for all the help @auouymous. This kind of marks my first open-sourced contribution to a high-rated repository. I'm glad to support Gpodder

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename already downloaded podcasts.

2 participants