Catch unknown sync exceptions when opening device and show error. #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some devices lack writable info and gpodder assumes they are writable. This can lead to an exception being thrown when not writable.
Member
|
Merged, thanks |
auouymous
added a commit
to auouymous/gpodder
that referenced
this pull request
Jun 13, 2025
PR gpodder#1401 queried the destination field only available in MP3PlayerDevice, causing iPod devices to throw an exception. This adds a description method to all devices that returns a string for use in sync errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices lack writable info and gpodder assumes they are writable. This can lead to an exception being thrown when not writable.
See #1371.