Skip to content

Conversation

@18928172992817182
Copy link
Contributor

Fixes the # TODO: watch URL does not work in europe due to GDPR cookie consent added in a2fc81e

@auouymous
Copy link
Member

Thank you! The number of videos returning 404 on old endpoint increased from one a day to all a day over the past week and I imagine this has caused problems for Europeans, even though the videos became available on the endpoint within a day. Now I don't have to fix it this weekend. I will look at your patch later today or tomorrow.

@tpikonen
Copy link
Contributor

tpikonen commented Jun 29, 2021

(Edit note: I was of course testing the unpatched gPodder before)

Thanks for the patch, it does fix the youtube downloads for me.

@auouymous
Copy link
Member

The get_video_info endpoint is 404 for the first ~24 hours after a release for everyone. The code then falls back to the new watch endpoint and works outside of Europe (and inside with this patch), even though users see a 404 warning. Once merged, I will flip the endpoints so watch is fetched first, and get_video_info will remain in case watch fails.

@tpikonen Thanks for testing. I'll probably just merge this tomorrow and fix the above issues myself to get this released.

@auouymous auouymous merged commit 82d926b into gpodder:master Jul 7, 2021
auouymous added a commit that referenced this pull request Jul 7, 2021
@auouymous
Copy link
Member

Thanks for the patch. It has been applied along with 14bf8b4 to fix the above issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants