marshal.go: updatePktSecurityParameters called with non v3 packet#314
Merged
TimRots merged 3 commits intogosnmp:masterfrom Mar 28, 2021
Merged
Conversation
d109e5b to
5542a4c
Compare
Hipska
suggested changes
Mar 25, 2021
2 tasks
5542a4c to
9944a69
Compare
Member
Author
|
Thanks for the first round of review @Hipska, |
9944a69 to
c714726
Compare
Hipska
approved these changes
Mar 26, 2021
Contributor
Hipska
left a comment
There was a problem hiding this comment.
Would it be possible to return the result anyway? Other tools then can inspect it if wanted/needed.
Member
Author
|
thanks for some more review @Hipska
that can be useful indeed, will update the PR. |
…ection or packet Signed-off-by: Tim Rots <tim.rots@protonmail.ch>
c714726 to
22f2d7f
Compare
Hipska
approved these changes
Mar 26, 2021
Signed-off-by: Tim Rots <tim.rots@protonmail.ch>
Contributor
|
Can you link #251 to be fixed by this PR as well? |
SuperQ
reviewed
Mar 28, 2021
Contributor
SuperQ
left a comment
There was a problem hiding this comment.
Some minor nits, otherwise great.
6047f87 to
30b89d5
Compare
Signed-off-by: Tim Rots <tim.rots@protonmail.ch>
30b89d5 to
792a7e5
Compare
Member
Author
|
Thanks for the reviews gents 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
marshal.go/sendOneRequest():
marshal.go/send():
updatePktSecurityParameterswith non v3 packetFixes #251 #307
Signed-off-by: Tim Rots tim.rots@protonmail.ch
Co-Authored-by: Thomas Casteleyn thomas.casteleyn@super-visions.com