Updated base URL for fetching news images#1443
Merged
Eskaan merged 1 commit intogorilla-devs:masterfrom Jan 16, 2023
Merged
Conversation
|
|
Collaborator
|
Why is this necessary? Could you please leave sources? |
Contributor
Author
|
https://minecraft.net is redirecting to https://www.minecraft.net. By setting the base URL to the latter, the launcher avoids having to establish more HTTP client connections than necessary, when fetching news images. Source: I work with infrastructure at Mojang |
Eskaan
pushed a commit
to Eskaan/GDLauncher
that referenced
this pull request
Nov 15, 2023
Eskaan
pushed a commit
to Eskaan/GDLauncher
that referenced
this pull request
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When fetching news from Mojang, there is typically an image to each news item. The base URL of the image should be https://www.minecraft.net/, and not https://minecraft.net/.
Approach
The change in this pull request ensures that https://www.minecraft.net/ is used as the base URL when fetching news images.