bugfix/subrouter custom methodNotAllowed handler returning 404 (#509)#510
Merged
elithrar merged 1 commit intogorilla:masterfrom Aug 26, 2019
Conversation
a9ce43a to
c4781b8
Compare
elithrar
suggested changes
Aug 20, 2019
Contributor
elithrar
left a comment
There was a problem hiding this comment.
Thanks for this - just one minor nit.
c4781b8 to
db220ca
Compare
Contributor
Author
|
happy to merge this @elithrar ? |
Contributor
|
Will take a final look this weekend! (busy week)
…On Sat, Aug 24, 2019 at 2:45 AM Jonas De Beukelaer ***@***.***> wrote:
happy to merge this @elithrar <https://github.com/elithrar> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#510?email_source=notifications&email_token=AAAEQ4G7A64FEPYQ5XJYJKDQGD7KDA5CNFSM4INRTP52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5B4Z7Q#issuecomment-524537086>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAEQ4CWN4B5HRB7YF6JPWLQGD7KDANCNFSM4INRTP5Q>
.
|
Contributor
|
Merged - thanks @jonasdebeukelaer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #509
Summary of Changes