Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

fix gorhill/uBlock#2179#275

Merged
JustOff merged 1 commit intogorhill:masterfrom
hawkeye116477:logger
Nov 7, 2020
Merged

fix gorhill/uBlock#2179#275
JustOff merged 1 commit intogorhill:masterfrom
hawkeye116477:logger

Conversation

@hawkeye116477
Copy link
Contributor

All is good described in issue description and can be reproduced with for example ppe.pl and EasyList.

In short when logger is opened and you then disable filterlist which had filter which was in logger, then when you click on that filter, blank message will be displayed, but should be written that Static filter could not be found in any of the currently enabled filter lists.

@JustOff
Copy link
Collaborator

JustOff commented Nov 7, 2020

Could you please place loggerStaticFilteringFinderSentence2 right after loggerStaticFilteringFinderSentence1?

Co-authored-by:  gorhill <585534+gorhill@users.noreply.github.com>
@hawkeye116477
Copy link
Contributor Author

Done.

@JustOff
Copy link
Collaborator

JustOff commented Nov 7, 2020

Thank you.

@JustOff JustOff merged commit a6b9213 into gorhill:master Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants