Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Warn when navigating away from pane with unsaved changes#264

Merged
JustOff merged 3 commits intogorhill:masterfrom
hawkeye116477:unsaved
Oct 10, 2020
Merged

Warn when navigating away from pane with unsaved changes#264
JustOff merged 3 commits intogorhill:masterfrom
hawkeye116477:unsaved

Conversation

@hawkeye116477
Copy link
Contributor

@hawkeye116477 hawkeye116477 commented Oct 9, 2020

Translations for other locales missing (dashboardUnsavedWarning dashboardUnsavedWarningStay dashboardUnsavedWarningIgnore).

hawkeye116477 and others added 3 commits October 9, 2020 23:08
Related issue:
- gorhill/uBlock#3271

When navigating away by clicking another pane tab button,
there will be an embedded warning, which can be ignore
in order to proceed to the new pane, or dismissed by
either clicking on the "Stay" button or anywhere else
in the dashboard.

When navigating away by trying to close the tab, there will
be a built-in browser warning asking for confirmation.

Co-authored-by:  gorhill <585534+gorhill@users.noreply.github.com>
Related issue:
- uBlockOrigin/uBlock-issues#905

Co-authored-by:  gorhill <585534+gorhill@users.noreply.github.com>
@JustOff
Copy link
Collaborator

JustOff commented Oct 10, 2020

I have added translations.

@JustOff JustOff merged commit ece30d3 into gorhill:master Oct 10, 2020
@hawkeye116477 hawkeye116477 deleted the unsaved branch October 10, 2020 13:53
@JustOff JustOff mentioned this pull request Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants