Skip to content

docs: added docs website, removed bindir#142

Merged
caarlos0 merged 1 commit intomasterfrom
docs
May 24, 2020
Merged

docs: added docs website, removed bindir#142
caarlos0 merged 1 commit intomasterfrom
docs

Conversation

@caarlos0
Copy link
Copy Markdown
Member

add website similar to the goreleaser one.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 merged commit 7b7ab3f into master May 24, 2020
@caarlos0 caarlos0 deleted the docs branch May 24, 2020 19:09
@nhooyr
Copy link
Copy Markdown

nhooyr commented May 27, 2020

Why was bindir removed in this PR?

nhooyr added a commit to coder/code-server that referenced this pull request May 27, 2020
@caarlos0
Copy link
Copy Markdown
Member Author

Because it was not used anymore, but I should have removed it in another pr...

@caarlos0 caarlos0 changed the title docs: added docs website docs: added docs website, removed bindir May 27, 2020
@nhooyr
Copy link
Copy Markdown

nhooyr commented May 27, 2020

Because it was not used anymore, but I should have removed it in another pr...

All good, was just making sure it wasn't some mistake as we were using it and it was breaking our builds.

Would be good to document such breaking changes.

nhooyr added a commit to coder/code-server that referenced this pull request May 27, 2020
@caarlos0
Copy link
Copy Markdown
Member Author

Good point, added to the release notes https://github.com/goreleaser/nfpm/releases/tag/v1.3.0

@caarlos0
Copy link
Copy Markdown
Member Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants