Skip to content

chore: Improve artisan about commmand unit test#794

Merged
hwbrzzl merged 2 commits intogoravel:masterfrom
almas-x:artisan-about
Dec 29, 2024
Merged

chore: Improve artisan about commmand unit test#794
hwbrzzl merged 2 commits intogoravel:masterfrom
almas-x:artisan-about

Conversation

@almas-x
Copy link
Contributor

@almas-x almas-x commented Dec 28, 2024 •
edited
Loading

📑 Description

Avoid using mock.Anything.

@coderabbitai summary

✅ Checks

  • Added test cases for my code

@almas-x almas-x requested a review from a team as a code owner December 28, 2024 03:34
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 28, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • 🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@almas-x
Copy link
Contributor Author

almas-x commented Dec 28, 2024

Review Ready

@codecov
Copy link

codecov bot commented Dec 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.81%. Comparing base (51df61c) to head (31dd6e9).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #794   +/-   ##
=======================================
  Coverage   69.81%   69.81%           
=======================================
  Files         217      217           
  Lines       18825    18825           
=======================================
  Hits        13142    13142           
  Misses       4969     4969           
  Partials      714      714

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hwbrzzl
hwbrzzl approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl merged commit 380a71a into goravel:master Dec 29, 2024
@almas-x almas-x deleted the artisan-about branch December 30, 2024 06:28
hwbrzzl added a commit that referenced this pull request Nov 15, 2025
@hwbrzzl
feat: [#794] Add WithCommands function (#1259)
6918a00 
* feat: [#786] Add WithCommands function

* AddCommand and AddMiddleware

* add tests

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@almas-x @hwbrzzl