feat: add OrWhereIn method#397
Merged
hwbrzzl merged 3 commits intogoravel:masterfrom Jan 27, 2024
Kamandlou:orm
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
=======================================
Coverage 69.36% 69.37%
=======================================
Files 152 152
Lines 10935 10937 +2
=======================================
+ Hits 7585 7587 +2
Misses 2844 2844
Partials 506 506 ☔ View full report in Codecov by Sentry. |
hwbrzzl
reviewed
Jan 27, 2024
contracts/database/orm/orm.go
Outdated
Comment on lines
+128
to
+129
| // OrWhereIn adds an "or where column in" clause to the query. | ||
| OrWhereIn(column string, values []any) Query |
Contributor
There was a problem hiding this comment.
Good implementation, just one nitpick: please sort the method by the first letter. 👍
hwbrzzl
approved these changes
Jan 27, 2024
1 task
krishankumar01
added a commit
that referenced
this pull request
Nov 29, 2024
krishankumar01
added a commit
that referenced
this pull request
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
add OrWhereIn method
✅ Checks