Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds facade installation capabilities for Event and Storage modules in the Goravel framework. It enables automatic generation of facade files and configuration when these modules are installed.
- Adds stub generation functionality for Event and Storage facades
- Implements conditional facade file management during install/uninstall operations
- Creates filesystem configuration stub for Storage module
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| filesystem/setup/stubs.go | Adds stub generators for Storage facade and filesystem configuration |
| filesystem/setup/setup.go | Updates setup to use stubs and handle Storage facade installation/removal |
| event/setup/stubs.go | Adds stub generator for Event facade |
| event/setup/setup.go | Updates setup to use stubs and handle Event facade installation/removal |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
==========================================
- Coverage 69.49% 69.15% -0.34%
==========================================
Files 229 231 +2
Lines 14391 14461 +70
==========================================
Hits 10001 10001
- Misses 4032 4102 +70
Partials 358 358 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alfanzain
pushed a commit
to alfanzain/goravel-framework
that referenced
this pull request
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Relate goravel/goravel#612
✅ Checks