add support for setting a system scope#181
add support for setting a system scope#181mandre merged 1 commit intogophercloud:masterfrom askarsabyrov:master
Conversation
|
@pierreprinetti could you please approve workflow? really need this fix, it would help to use system scoped authorization for terraform-openstack-provider. |
|
@mandre hi, can you have a look please? really need this to be merged, thanks! |
Sure, I'll check it soon. Sorry for the delay. |
mandre
left a comment
There was a problem hiding this comment.
Since you need to update the patch anyway, may I suggest you also credit @ignatenkobrain in the commit message as he was the one who wrote the original patch?
You can do it by adding a Co-authored-by: Igor Raits <igor.raits@gooddata.com> line at the end of the commit message (see the related github docs).
openstack/clientconfig/results.go
Outdated
| ApplicationCredentialSecret string `yaml:"application_credential_secret,omitempty" json:"application_credential_secret,omitempty"` | ||
|
|
||
| // SystemScope is a system information to scope to. | ||
| SystemScope string `yaml:"system_scope,omitempty" json:"system_scope,omitempty"` |
There was a problem hiding this comment.
You have an additional whitespace in there that causes the unit tests to fail.
| SystemScope string `yaml:"system_scope,omitempty" json:"system_scope,omitempty"` | |
| SystemScope string `yaml:"system_scope,omitempty" json:"system_scope,omitempty"` |
There was a problem hiding this comment.
Removed space and added credits to @ignatenkobrain in the commit.
Co-authored-by: Igor Raits <igor.raits@gooddata.com>
mandre
left a comment
There was a problem hiding this comment.
Looks good, thanks for the patch.
Fixes: #166
Reopened PR #167