Add support for setting a System scope#167
Closed
igor-raits wants to merge 1 commit intogophercloud:masterfrom
Closed
Add support for setting a System scope#167igor-raits wants to merge 1 commit intogophercloud:masterfrom
igor-raits wants to merge 1 commit intogophercloud:masterfrom
Conversation
Fixes: gophercloud#166 Signed-off-by: Igor Raits <igor.raits@gooddata.com>
ZdenekPesek
reviewed
Jan 19, 2022
| } else if cloud.AuthInfo.DomainName != "" { | ||
| scope.DomainName = cloud.AuthInfo.DomainName | ||
| } | ||
| if cloud.AuthInfo.SystemScope != "" { |
There was a problem hiding this comment.
@ignatenkobrain
would you mind to add SystemScope into section above to build that option also from ENV and have it all covered? :)
if cloud.AuthInfo.SystemScope == "" {
if v := env.Getenv(envPrefix + "SYSTEM_SCOPE"); v != "" {
cloud.AuthInfo.SystemScope = v
}
}
Contributor
There was a problem hiding this comment.
@ignatenkobrain really need this fix, could you please push proposed changes?
Contributor
There was a problem hiding this comment.
@ZdenekPesek can I reopen this PR with those changes?
Contributor
Author
There was a problem hiding this comment.
yes please, we sadly don't have much time/skills to push this through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #166
Signed-off-by: Igor Raits igor.raits@gooddata.com