Merged
Conversation
|
Build succeeded.
|
Contributor
|
LGTM - thanks! |
cardoe
pushed a commit
to cardoe/gophercloud
that referenced
this pull request
Aug 27, 2020
* Add `prefix_length` to subnet create * Added subnet pool prefix length test cases * Correctly named test case * Improved checks for `prefix_length` * Added conflict with `cidr` * Check if `subnetpool_id` is set before setting `prefix_length`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #540
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API reference:
https://developer.openstack.org/api-ref/compute/#delete-an-extra-spec-for-a-flavor
Nova implementation:
https://github.com/openstack/nova/blob/stable/pike/nova/api/openstack/compute/flavors_extraspecs.py#L111
There is a note in the above that the error should be 204, rather than the 200 that is returned. The value in the API spec is also 200. Testing proved that the return code is 200 rather than 204.