Merged
Conversation
jtopjian
requested changes
Nov 4, 2017
Contributor
jtopjian
left a comment
There was a problem hiding this comment.
Since there's a bug with updating Extra, perhaps it would be best to leave it out for now?
I think simply commenting the code out with a link to the bug would be fine. This way, when the bug is fixed, the code can be re-enabled without a lot of work.
It'd also be a good idea to add a doc comment that updating Extra will only be valid from the point of the bug being fixed, once it is fixed.
Also added some doc nits since since a larger change is required.
Let me know your thoughts on the above :)
|
|
||
| region, err := regions.Create(identityClient, createOpts).Extract() | ||
| if err != nil { | ||
| panic(err) |
| regionID := "TestRegion" | ||
| err := regions.Delete(identityClient, regionID).ExtractErr() | ||
| if err != nil { | ||
| } |
jtopjian
approved these changes
Nov 7, 2017
Contributor
|
Looks good. Thank you, @dklyle! |
cardoe
pushed a commit
to cardoe/gophercloud
that referenced
this pull request
Aug 27, 2020
If "admin_state_up" is not specified in the API request, then the port should default to an admin_state_up of "UP". Currently, this resource will always send a value of "false", even if the user did not specify it in their resource configuration. This commit fixes this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that ID cannot be updated even though it is settable on create.
There is also currently an issue with updating the Extra field. This I believe is
a bug in keystone. I have posted a bug and patch to fix. https://bugs.launchpad.net/keystone/+bug/1729933
For #583
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API:
https://developer.openstack.org/api-ref/identity/v3/#update-region
Schema:
https://github.com/openstack/keystone/blob/2764b49bc209245276da31693ef31f1525cf17d8/keystone/catalog/backends/sql.py#L175
Update:
https://github.com/openstack/keystone/blob/2764b49bc209245276da31693ef31f1525cf17d8/keystone/catalog/controllers.py#L83