Skip to content

Identity v3 region delete#587

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
dklyle:region-delete
Nov 4, 2017
Merged

Identity v3 region delete#587
jtopjian merged 2 commits intogophercloud:masterfrom
dklyle:region-delete

Conversation

@dklyle
Copy link
Copy Markdown
Contributor

@dklyle dklyle commented Nov 1, 2017

For #583

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

Delete:
https://github.com/openstack/keystone/blob/2764b49bc209245276da31693ef31f1525cf17d8/keystone/catalog/controllers.py#L92

@dklyle dklyle mentioned this pull request Nov 1, 2017
4 tasks
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 72.275% when pulling f2b387e on dklyle:region-delete into e7fa81e on gophercloud:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 3, 2017

Coverage Status

Coverage increased (+0.03%) to 72.244% when pulling 8676c7b on dklyle:region-delete into 754e57e on gophercloud:master.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Nov 4, 2017

Looks like the sample code in doc.go is a little off, but I see you've touched most of it up on the Update PR. Definitely fixable post-merge.

@jtopjian jtopjian merged commit fbfb948 into gophercloud:master Nov 4, 2017
@dklyle dklyle deleted the region-delete branch November 16, 2017 21:31
cardoe pushed a commit to cardoe/gophercloud that referenced this pull request Aug 27, 2020
* Compute v2: add flavor_id to flavor data source

* Compute v2: flavor data source code review

* Compute V2: update flavor filter

* Compute V2: update acceptance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants