Skip to content

Identity v3: Region list / get#584

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
dklyle:regions-list
Nov 1, 2017
Merged

Identity v3: Region list / get#584
jtopjian merged 1 commit intogophercloud:masterfrom
dklyle:regions-list

Conversation

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 1, 2017

Coverage Status

Coverage increased (+0.06%) to 72.244% when pulling fae8b02 on dklyle:regions-list into c7551a6 on gophercloud:master.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Nov 1, 2017

Looks good!

@jtopjian jtopjian merged commit e7fa81e into gophercloud:master Nov 1, 2017
@dklyle dklyle mentioned this pull request Nov 1, 2017
4 tasks
@dklyle dklyle deleted the regions-list branch November 3, 2017 22:19
cardoe pushed a commit to cardoe/gophercloud that referenced this pull request Aug 27, 2020
* Internal: cleanup Networking V2 Ports

Add StateRefreshFunc(), expandNetworkingPortFixedIpsV2 into the
"networking_port_v2.go".

Change "fixed_ip" argument type to "TypeSet".

Use "expandToStringSlice()" function to retrieve "security_groups"
value. This change also affects "openstack_lb_loadbalancer_v2" resource
code.

Add common "boolPtrArgument()" into "util.go" to work with some special
arguments like "admin_state_up".

Fix debug and error messages.

* Internal: Use TypeSet for Ports V2 all_fixed_ips

We should remove dependency of ordering of the IPs inside the
"all_fixed_ip" attribute for openstack_networking_port_v2 resource and
datasource.

* Networking V2 Port IDs data: fix securityGroups

Use expandToStringSlice() for getting securityGroups in the
"data_source_openstack_networking_port_ids_v2".

* Networking V2 ports: revert all_fixed_ips TypeSet

Leave TypeList for "all_fixed_ips" argument in the
openstack_networking_port_v2 resource and datasource.

* Networking V2: cleanup ports datasources messages

Use "openstack_networking_port_v2" as object name for the
openstack_networking_port_ids_v2 and openstack_networking_port_v2
datasources.

* Util: remove boolPtrArgument()

Remove boolPtrArgument() as it won't be used.

* Networking V2 Port: use TypeList for fixed_ip

Use TypeList for "fixed_ip" argument and add tests for the
expandNetworkingPortFixedIPV2() helper function.

* Networking V2 Ports: return addr pairs hash

Use custom resourceNetworkingPortV2AllowedAddressPairsHash() function
for "allowed_address_pairs" set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants