Identity v3: Region list / get#584
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Nov 1, 2017
Merged
Conversation
Contributor
|
Looks good! |
cardoe
pushed a commit
to cardoe/gophercloud
that referenced
this pull request
Aug 27, 2020
* Internal: cleanup Networking V2 Ports Add StateRefreshFunc(), expandNetworkingPortFixedIpsV2 into the "networking_port_v2.go". Change "fixed_ip" argument type to "TypeSet". Use "expandToStringSlice()" function to retrieve "security_groups" value. This change also affects "openstack_lb_loadbalancer_v2" resource code. Add common "boolPtrArgument()" into "util.go" to work with some special arguments like "admin_state_up". Fix debug and error messages. * Internal: Use TypeSet for Ports V2 all_fixed_ips We should remove dependency of ordering of the IPs inside the "all_fixed_ip" attribute for openstack_networking_port_v2 resource and datasource. * Networking V2 Port IDs data: fix securityGroups Use expandToStringSlice() for getting securityGroups in the "data_source_openstack_networking_port_ids_v2". * Networking V2 ports: revert all_fixed_ips TypeSet Leave TypeList for "all_fixed_ips" argument in the openstack_networking_port_v2 resource and datasource. * Networking V2: cleanup ports datasources messages Use "openstack_networking_port_v2" as object name for the openstack_networking_port_ids_v2 and openstack_networking_port_v2 datasources. * Util: remove boolPtrArgument() Remove boolPtrArgument() as it won't be used. * Networking V2 Port: use TypeList for fixed_ip Use TypeList for "fixed_ip" argument and add tests for the expandNetworkingPortFixedIPV2() helper function. * Networking V2 Ports: return addr pairs hash Use custom resourceNetworkingPortV2AllowedAddressPairsHash() function for "allowed_address_pairs" set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #583
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API:
https://developer.openstack.org/api-ref/identity/v3/#regions
Schema:
https://github.com/openstack/keystone/blob/2764b49bc209245276da31693ef31f1525cf17d8/keystone/catalog/backends/sql.py#L34
https://github.com/openstack/keystone/blob/2764b49bc209245276da31693ef31f1525cf17d8/keystone/catalog/schema.py#L22
List:
https://github.com/openstack/keystone/blob/2764b49bc209245276da31693ef31f1525cf17d8/keystone/catalog/controllers.py#L70
Get:
https://github.com/openstack/keystone/blob/2764b49bc209245276da31693ef31f1525cf17d8/keystone/catalog/controllers.py#L78