Add TSIG key support for OpenStack DNS v2 API#3623
Merged
mandre merged 1 commit intogophercloud:mainfrom Feb 18, 2026
Merged
Conversation
mandre
reviewed
Feb 12, 2026
Contributor
|
Apart from the the missing required ResourceID, this looks good. We can merge once this passes CI. |
b0f3f1e to
dadacb2
Compare
Contributor
Author
|
I have switched it to be |
Contributor
|
You'll need to update the acceptance tests too. |
Implement TSIG (Transaction SIGnature) key management for the Designate DNS service, enabling authentication of DNS transactions between servers for zone transfers and dynamic updates. Fixes gophercloud#3622 Signed-off-by: Omer <omersch381@gmail.com>
dadacb2 to
53881b9
Compare
Contributor
Author
|
While investigating the acceptance tests, I tested TSIG key creation on my devstack machine and I saw that creating TSIG keys with POOL scope requires admin privileges. I hope I added those in the correct place. Thanks for the comment. |
mandre
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement TSIG (Transaction SIGnature) key management for the Designate DNS service, enabling authentication of DNS transactions between servers for zone transfers and dynamic updates.
Fixes #3622
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API Controller (REST endpoints):
https://github.com/openstack/designate/blob/master/designate/api/v2/controllers/tsigkeys.py
Service Implementation (CRUD methods): https://github.com/openstack/designate/blob/master/designate/central/service.py#L618-L670
TSIG Key Object Definition:
https://github.com/openstack/designate/blob/master/designate/objects/tsigkey.py
Python Client Reference:
https://github.com/openstack/python-designateclient/blob/master/designateclient/v2/tsigkeys.py