Skip to content

[v2] fix (image/v2/images): image v2 unmarshal issue#3590

Merged
kayrus merged 3 commits intov2from
bp-v2-c830e59-83f935c-7736038
Dec 19, 2025
Merged

[v2] fix (image/v2/images): image v2 unmarshal issue#3590
kayrus merged 3 commits intov2from
bp-v2-c830e59-83f935c-7736038

Conversation

@gophercloud-backport-bot
Copy link
Copy Markdown

Backport: #3589

This PR address the unmarshal issue when user add an additional property properties to the image using openstack image set <IMAGE> --property <KEY>=<VALUE> ..., which collides with the field in Image.Properties with a type of map[string]any.

Fixes #3588

See the issue above to reproduce a test case.

@github-actions github-actions bot added edit:image This PR updates image code v2 This PR targets v2 semver:patch No API change backport-v2 This PR will be backported to v2 labels Dec 19, 2025
@kayrus kayrus merged commit 36ef673 into v2 Dec 19, 2025
18 checks passed
@kayrus kayrus deleted the bp-v2-c830e59-83f935c-7736038 branch December 19, 2025 10:55
@github-actions
Copy link
Copy Markdown

Failed to backport PR to v2 branch. See logs for details.

@Pjack
Copy link
Copy Markdown

Pjack commented Dec 22, 2025

@kayrus backport failed. Just a reminder.

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Dec 22, 2025

@kayrus backport failed. Just a reminder.

@Pjack This PR was submitted against the v2 branch, so it's odd that the bot added the backport-v2 label to try to merge it again in v2. But anyway, you can check the changes made it to v2.

mandre added a commit to shiftstack/gophercloud that referenced this pull request Dec 22, 2025
As seen in [1], we shouldn't add the `backport-v2` label to PRs that are
already submitted against `v2` branch.

[1] gophercloud#3590 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:image This PR updates image code semver:patch No API change v2 This PR targets v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants