fix (image/v2/images): image v2 unmarshal issue#3589
Merged
kayrus merged 3 commits intogophercloud:mainfrom Dec 19, 2025
Merged
fix (image/v2/images): image v2 unmarshal issue#3589kayrus merged 3 commits intogophercloud:mainfrom
kayrus merged 3 commits intogophercloud:mainfrom
Conversation
kayrus
reviewed
Dec 18, 2025
Contributor
|
Thanks for the PR. See my comment above. In addition could you please add functional tests to cover this case? |
Contributor
Author
|
I will provide some functional tests later |
Contributor
Author
|
I updated the |
This was referenced Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address the unmarshal issue when user add an additional property
propertiesto the image usingopenstack image set <IMAGE> --property <KEY>=<VALUE> ..., which collides with the field inImage.Propertieswith a type ofmap[string]any.Fixes #3588
See the issue above to reproduce a test case.