Skip to content

identity.v3.Endpoint: make name as optional on creation#3581

Merged
mandre merged 1 commit intogophercloud:mainfrom
winiciusallan:endpoint-name-optional
Jan 3, 2026
Merged

identity.v3.Endpoint: make name as optional on creation#3581
mandre merged 1 commit intogophercloud:mainfrom
winiciusallan:endpoint-name-optional

Conversation

@winiciusallan
Copy link
Copy Markdown
Contributor

The name field is optional on Endpoint creation following the API reference, but Gophercloud defines this field as required.

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://docs.openstack.org/api-ref/identity/v3/index.html#create-endpoint

@github-actions github-actions bot added edit:identity This PR updates identity code semver:patch No API change backport-v2 This PR will be backported to v2 labels Dec 12, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 12, 2025

Coverage Status

coverage: 63.781%. remained the same
when pulling d2e0b94 on winiciusallan:endpoint-name-optional
into f50e455 on gophercloud:main.

@winiciusallan
Copy link
Copy Markdown
Contributor Author

winiciusallan commented Dec 12, 2025

Should we want to drop the Name field on the next release since it is deprecated (according to docs)?

If so, I can change this pull request to do it instead of just making it optional.

mandre
mandre previously approved these changes Jan 2, 2026
@mandre
Copy link
Copy Markdown
Contributor

mandre commented Jan 2, 2026

Should we want to drop the Name field on the next release since it is deprecated (according to docs)?

If so, I can change this pull request to do it instead of just making it optional.

Let's make it optional now (and backport to v2) and have another PR that drops it from main (not backported to v2).

edit: we should resurrect #3017 for the one that we'll merge to main.

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Jan 2, 2026

@winiciusallan could you resolve the conflict (due to #3584)?

@winiciusallan
Copy link
Copy Markdown
Contributor Author

@winiciusallan could you resolve the conflict (due to #3584)?

Done! =)

@mandre mandre added this pull request to the merge queue Jan 3, 2026
Merged via the queue into gophercloud:main with commit 02dbf35 Jan 3, 2026
62 checks passed
@winiciusallan winiciusallan deleted the endpoint-name-optional branch January 3, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:identity This PR updates identity code semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants